Python 3.11 + FA 2.5.0 + Torch 2.3.0 #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/composer into version-upgrade-vincent
…-debugger-vincent
j316chuck
approved these changes
Jan 25, 2024
j316chuck
requested changes
Jan 26, 2024
j316chuck
approved these changes
Jan 26, 2024
j316chuck
approved these changes
Jan 26, 2024
mvpatel2000
reviewed
Jan 26, 2024
mvpatel2000
approved these changes
Jan 26, 2024
ShashankMosaicML
pushed a commit
to ShashankMosaicML/composer
that referenced
this pull request
Feb 3, 2024
* image version update * update builder * remove torch 1.13 * possible snappy fix * moved changes to generate_build_matrix * 3.11 support * test * version test * remove snappy test * add 3.10 + 3.11 * potential snappy fix * nightly patch * debug * debug * extrapolated pytorch to depend on python version * python 3.8 deprecation assertion * removed deprecation * removing import for test * lint * lint * pr review changes * apt install snappy before pip install * lint * disk usage print logs * du depth 3 * syntax * more syntax * syntax * syntax * inspect root * depth 1 * debug * remove sys and proc from du * install fa2 through pip * install dependancy * no build isolation * setuptools * downgrade to 2.3.6 * 2 workers * revert * flash 1.0.9 * flash 2.3.6 * lint * fa 2.5.0 * nightly 3.11 * type * remove python 3.11 and torch 2.1.2 * remove timeout * reset latest version * smoke test update * lint * update yaml * 2.3.6 test * revert test * reversion continued * restoring from before reversion * max jobs * increase timeout * increase timeout * revert to only include nightly change * reset to default build time * update docker yaml * new names * merge * fix merge * lint * cpu-3.11-nightly test * temp rm test * cpu unit tst * rm test
ShashankMosaicML
pushed a commit
to ShashankMosaicML/composer
that referenced
this pull request
Feb 3, 2024
* image version update * update builder * remove torch 1.13 * possible snappy fix * moved changes to generate_build_matrix * 3.11 support * test * version test * remove snappy test * add 3.10 + 3.11 * potential snappy fix * nightly patch * debug * debug * extrapolated pytorch to depend on python version * python 3.8 deprecation assertion * removed deprecation * removing import for test * lint * lint * pr review changes * apt install snappy before pip install * lint * disk usage print logs * du depth 3 * syntax * more syntax * syntax * syntax * inspect root * depth 1 * debug * remove sys and proc from du * install fa2 through pip * install dependancy * no build isolation * setuptools * downgrade to 2.3.6 * 2 workers * revert * flash 1.0.9 * flash 2.3.6 * lint * fa 2.5.0 * nightly 3.11 * type * remove python 3.11 and torch 2.1.2 * remove timeout * reset latest version * smoke test update * lint * update yaml * 2.3.6 test * revert test * reversion continued * restoring from before reversion * max jobs * increase timeout * increase timeout * revert to only include nightly change * reset to default build time * update docker yaml * new names * merge * fix merge * lint * cpu-3.11-nightly test * temp rm test * cpu unit tst * rm test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements python 3.11 support for torch nightly using flash attention 2.5.0. The docker image has passed corgi regression tests on llm-foundry as well as has been tested in an interactive using the following set up from llm foundry:
mosaicml/llm-foundry#913